tests/conftest.py (1)

747-749: Align indentation of new feature flags with existing entries

The indentation of "supportNfc" and "hasFingerprintSensor" is inconsistent with the other entries in NEW_CAMERA_FEATURE_FLAGS. For consistency and readability, please adjust the indentation.

Apply this diff to fix the indentation:

 # 4.73.71+
-        "supportNfc",
-        "hasFingerprintSensor",
+    "supportNfc",
+    "hasFingerprintSensor",

tests/sample_data/sample_camera.json (2)

471-471: Maintain consistent naming convention for feature flags

While the addition of NFC and fingerprint sensor flags is appropriate, the naming convention should be consistent with other hardware capability flags in the configuration.

Consider updating the NFC flag to follow the "has" prefix convention:

         "hasFingerprintSensor": true,
         "mountPositions": [],
         "smartDetectTypes": [
             "person",
             "vehicle"
         ],
-        "supportNfc": true,
+        "hasNfc": true,
         "motionAlgorithms": [

Also applies to: 477-477

---

471-477: Consider grouping related feature flags

For better maintainability and readability, consider grouping related hardware capability flags together (e.g., authentication-related features like NFC, fingerprint sensor, and biometrics).

Consider moving these flags next to other hardware-related flags like hasBluetooth or hasLcdScreen to maintain a logical grouping.

src/uiprotect/data/devices.py (2)

862-864: LGTM! Consider adding docstrings for the new feature flags.

The new feature flags follow the established naming conventions and type patterns. Consider adding docstrings to describe their purpose and usage.

    # 4.73.71+
-   support_nfc: bool | None = None
-   has_fingerprint_sensor: bool | None = None
+   # Whether the camera supports NFC card scanning capabilities
+   support_nfc: bool | None = None
+   # Whether the camera has a fingerprint sensor for biometric authentication
+   has_fingerprint_sensor: bool | None = None

---

862-864: Consider adding helper properties for the new feature flags.

For consistency with other feature flags in the codebase, consider adding helper properties to the Camera class to check these capabilities.

Add these properties to the Camera class:

@property
def is_nfc_supported(self) -> bool:
    """Whether the camera supports NFC card scanning."""
    return self.feature_flags.support_nfc is True

@property
def has_fingerprint(self) -> bool:
    """Whether the camera has a fingerprint sensor."""
    return self.feature_flags.has_fingerprint_sensor is True

tests/sample_data/sample_bootstrap.json (1)

Line range hint 1-2024: Consider adding documentation for new feature flags.

The new feature flags have been added but there's no documentation explaining their purpose or expected behavior. Consider adding comments or documentation to describe:

• When these features are enabled/disabled
• How they interact with other settings
• Any dependencies or requirements

Configuration used: CodeRabbit UI
Review profile: CHILL